Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature: optimize TCC structure, supporting API access #5165

Merged
merged 145 commits into from
Jan 31, 2023
Merged

feature: optimize TCC structure, supporting API access #5165

merged 145 commits into from
Jan 31, 2023

Conversation

sunrui1225
Copy link
Contributor

  • I have registered the PR changes.

Ⅰ. Describe what this PR did

This PR solve the dependency issue between seata-spring and seata-tcc. the seata-tcc should depend on seata-spring, but they are opposite now.
we made new modern commom-api for seata-spring and seata-tcc.

Ⅱ. Does this pull request fix one issue?

Ⅲ. Why don't you add test cases (unit test/integration test)?

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

sunrui1225 and others added 30 commits May 26, 2022 20:18
…ncy_manual_api

# Conflicts:
#	common/src/main/java/io/seata/common/Constants.java
#	common/src/main/java/io/seata/common/DefaultValues.java
#	spring/src/main/java/io/seata/spring/fence/CommonFenceHandler.java
#	spring/src/main/java/io/seata/spring/fence/store/CommonFenceStore.java
#	spring/src/main/java/io/seata/spring/fence/store/db/CommonFenceStoreDataBaseDAO.java
#	spring/src/main/java/io/seata/spring/fence/store/db/sql/CommonFenceStoreSqls.java
#	spring/src/main/java/io/seata/spring/interceptor/ActionInterceptorHandler.java
#	spring/src/main/java/io/seata/spring/interceptor/TxAnnotationProcessor.java
#	spring/src/main/java/io/seata/spring/interceptor/TxBeanParserUtils.java
#	spring/src/main/java/io/seata/spring/remoting/RemotingDesc.java
#	spring/src/main/java/io/seata/spring/remoting/parser/DefaultRemotingParser.java
#	spring/src/main/java/io/seata/spring/remoting/parser/DubboRemotingParser.java
#	tcc/pom.xml
#	tcc/src/main/java/io/seata/rm/tcc/interceptor/TccActionInterceptor.java
#	tcc/src/main/java/io/seata/rm/tcc/remoting/parser/LocalTCCRemotingParser.java
@funky-eyes funky-eyes added this to the 2.0.0 milestone Jan 16, 2023
funky-eyes
funky-eyes previously approved these changes Jan 16, 2023
Copy link
Contributor

@funky-eyes funky-eyes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
1.向下兼容性测试通过
2.api方式代理通过
3.切点表达式通过

@funky-eyes funky-eyes changed the title Spring tcc dependency manual api optimize: Spring tcc dependency manual api Jan 16, 2023
@funky-eyes funky-eyes changed the title optimize: Spring tcc dependency manual api feature: Spring tcc dependency manual api Jan 30, 2023
@funky-eyes funky-eyes added type: feature Category issues or prs related to feature request. and removed type: optimize labels Jan 30, 2023
@funky-eyes funky-eyes changed the base branch from develop to 2.x January 30, 2023 01:53
@funky-eyes funky-eyes dismissed their stale review January 30, 2023 01:53

The base branch was changed.

# Conflicts:
#	build/pom.xml
#	common/src/main/java/io/seata/common/DefaultValues.java
#	spring/src/main/java/io/seata/spring/annotation/GlobalTransactionScanner.java
rerun ci

rerun ci
…' into spring_tcc_dependency_manual_api

# Conflicts:
#	spring/src/main/java/io/seata/spring/annotation/AspectTransactionalInterceptor.java
@sunrui1225 sunrui1225 changed the title feature: Spring tcc dependency manual api feature: optimize TCC structure, supporting API access. Jan 30, 2023
@wangliang181230
Copy link
Contributor

wangliang181230 commented Jan 31, 2023

Version.java 类里的版本号没改。

Copy link
Contributor

@funky-eyes funky-eyes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@wangliang181230 wangliang181230 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wangliang181230 wangliang181230 changed the title feature: optimize TCC structure, supporting API access. feature: optimize TCC structure, supporting API access Jan 31, 2023
@wangliang181230 wangliang181230 merged commit c7fba75 into apache:2.x Jan 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
first-time contributor first-time contributor module/spring spring module module/tcc tcc module type: feature Category issues or prs related to feature request.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants