-
Notifications
You must be signed in to change notification settings - Fork 8.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feature: optimize TCC structure, supporting API access #5165
feature: optimize TCC structure, supporting API access #5165
Conversation
…nto feature_spring_tcc_dependency
…nto feature_spring_tcc_dependency
…ncy_manual_api # Conflicts: # common/src/main/java/io/seata/common/Constants.java # common/src/main/java/io/seata/common/DefaultValues.java # spring/src/main/java/io/seata/spring/fence/CommonFenceHandler.java # spring/src/main/java/io/seata/spring/fence/store/CommonFenceStore.java # spring/src/main/java/io/seata/spring/fence/store/db/CommonFenceStoreDataBaseDAO.java # spring/src/main/java/io/seata/spring/fence/store/db/sql/CommonFenceStoreSqls.java # spring/src/main/java/io/seata/spring/interceptor/ActionInterceptorHandler.java # spring/src/main/java/io/seata/spring/interceptor/TxAnnotationProcessor.java # spring/src/main/java/io/seata/spring/interceptor/TxBeanParserUtils.java # spring/src/main/java/io/seata/spring/remoting/RemotingDesc.java # spring/src/main/java/io/seata/spring/remoting/parser/DefaultRemotingParser.java # spring/src/main/java/io/seata/spring/remoting/parser/DubboRemotingParser.java # tcc/pom.xml # tcc/src/main/java/io/seata/rm/tcc/interceptor/TccActionInterceptor.java # tcc/src/main/java/io/seata/rm/tcc/remoting/parser/LocalTCCRemotingParser.java
…nto feature_spring_tcc_dependency
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
1.向下兼容性测试通过
2.api方式代理通过
3.切点表达式通过
# Conflicts: # build/pom.xml # common/src/main/java/io/seata/common/DefaultValues.java # spring/src/main/java/io/seata/spring/annotation/GlobalTransactionScanner.java
…' into spring_tcc_dependency_manual_api # Conflicts: # spring/src/main/java/io/seata/spring/annotation/AspectTransactionalInterceptor.java
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Ⅰ. Describe what this PR did
This PR solve the dependency issue between seata-spring and seata-tcc. the seata-tcc should depend on seata-spring, but they are opposite now.
we made new modern commom-api for seata-spring and seata-tcc.
Ⅱ. Does this pull request fix one issue?
Ⅲ. Why don't you add test cases (unit test/integration test)?
Ⅳ. Describe how to verify it
Ⅴ. Special notes for reviews